Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check store has value before use it #3257

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Check store has value before use it #3257

merged 1 commit into from
Jun 20, 2023

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Jun 19, 2023 •
edited
Loading

What does this PR do?

Check that the store object has value before use it.

Motivation

We found logs with the catched error.

@uurien uurien requested a review from a team as a code owner June 19, 2023 15:55
@uurien uurien force-pushed the uurien/fix-nullable-store branch from 96f31cd to 4aaa864 Compare June 19, 2023 15:55
@github-actions
Copy link

github-actions bot commented Jun 19, 2023 •
edited
Loading

Overall package size

Self size: 4.36 MB
Deduped: 60.72 MB
No deduping: 60.77 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.3.1 784.66 kB 1.37 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited
Loading

Codecov Report

Merging #3257 (c213023) into master (bce0ee1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3257      +/-   ##
==========================================
+ Coverage   86.03%   86.05%   +0.02%     
==========================================
  Files         194      194              
  Lines        7517     7517              
  Branches       33       33              
==========================================
+ Hits         6467     6469       +2     
+ Misses       1050     1048       -2
Impacted Files Coverage Δ
...rc/appsec/iast/analyzers/sql-injection-analyzer.js 85.00% <100.00%> (+5.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Jun 19, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit c213023 in PR branch uurien/fix-nullable-store with baseline commit bce0ee1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 459 metrics, 33 unstable metrics.

@uurien uurien force-pushed the uurien/fix-nullable-store branch from 4aaa864 to 650a1e8 Compare June 20, 2023 07:05
@uurien uurien force-pushed the uurien/fix-nullable-store branch from 650a1e8 to c213023 Compare June 20, 2023 11:37
@uurien uurien merged commit 30ca014 into master Jun 20, 2023
@uurien uurien deleted the uurien/fix-nullable-store branch June 20, 2023 12:33
nsavoire pushed a commit that referenced this pull request Jun 21, 2023
@uurien @nsavoire
Check store has value before use it (#3257)
93397d3
nsavoire pushed a commit that referenced this pull request Jun 21, 2023
@uurien @nsavoire
Check store has value before use it (#3257)
b0e7973
nsavoire pushed a commit that referenced this pull request Jun 21, 2023
@uurien @nsavoire
Check store has value before use it (#3257)
809e3c3
This was referenced Jun 21, 2023
Merged
Merged
Merged
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
@uurien @tlhunter
Check store has value before use it (#3257)
1f1e481
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
@uurien @tlhunter
Check store has value before use it (#3257)
64764dc
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
@uurien @tlhunter
Check store has value before use it (#3257)
0fdc9be
@erikvanbrakel erikvanbrakel mentioned this pull request Jul 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iunanua iunanua iunanua approved these changes

Assignees
No one assigned
Labels
asm-iast semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uurien @iunanua